docs: Added documentation for Django/Flask integrations and dictConfig#848
Merged
gkevinzheng merged 7 commits intomainfrom Feb 14, 2024
Merged
docs: Added documentation for Django/Flask integrations and dictConfig#848gkevinzheng merged 7 commits intomainfrom
gkevinzheng merged 7 commits intomainfrom
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
size: m
daniel-sanche
approved these changes
Feb 12, 2024
Contributor
daniel-sanche
left a comment
daniel-sanche
left a comment
There was a problem hiding this comment.
LGTM, with a few small suggestions
| "handlers": { | ||
| "cloud_logging": { | ||
| "class": "google.cloud.logging.handlers.CloudLoggingHandler", | ||
| "client": client, |
Contributor
There was a problem hiding this comment.
maybe the client setup should be part of the sample?
docs/web-framework-integration.rst
Outdated
|
|
||
| Django integration has been tested to work with each of the Django/Python versions listed `here <https://docs.djangoproject.com/en/5.0/faq/install/#what-python-version-can-i-use-with-django>`_. | ||
| To enable Django integration, add `google.cloud.logging_v2.handlers.middleware.RequestMiddleware` to the list of `MIDDLEWARE` | ||
| in your settings file. Also be sure to :doc:`set up logging </std-lib-integration>` in your settings file. |
Contributor
There was a problem hiding this comment.
Maybe add a link like this to "settings file"? https://docs.djangoproject.com/en/5.0/topics/settings/
gkevinzheng
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
glasnt
reviewed
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dictConfigFixes #429
Fixes #844